From: Alexey Dobriyan <adobriyan@gmail.com>
To: jamal <hadi@cyberus.ca>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: regression due to "flush SAD/SPD generate false events"
Date: Thu, 18 Feb 2010 20:55:10 +0200 [thread overview]
Message-ID: <20100218185510.GA18829@x200> (raw)
In-Reply-To: <1266449529.17794.157.camel@bigi>
On Wed, Feb 17, 2010 at 06:32:09PM -0500, jamal wrote:
> On Wed, 2010-02-17 at 18:07 -0500, jamal wrote:
> > When you flush
> > an empty table, the time goes up from about 1.5s
> > to 3 secs with pfkey. You also see the EAGAIN for
> > each flush ...
> > I am going to dig a little more ..
>
> Here is a fix. The speed is restored (actually looks a little better
> now) - the only thing is if you try to flush an empty table we return
> -ESRCH; this seems reasonable, no? So a script like following
>
> ---
> #!/usr/sbin/setkey -f
> flush;
> spdflush;
> ----
>
> will get:
> ---
> bigismall:~# time setkey -f ./setkey-sample
> The result of line 2: No such process.
> The result of line 3: No such process.
I'd expect flushing empty SAD/SPD to be exact nops. :^)
next prev parent reply other threads:[~2010-02-18 19:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 19:17 regression due to "flush SAD/SPD generate false events" Alexey Dobriyan
2010-02-17 21:42 ` David Miller
2010-02-17 23:34 ` jamal
2010-02-17 23:40 ` David Miller
2010-02-17 23:49 ` jamal
2010-02-17 23:55 ` David Miller
2010-02-18 0:03 ` jamal
2010-02-17 21:42 ` jamal
2010-02-17 23:07 ` jamal
2010-02-17 23:32 ` jamal
2010-02-18 18:55 ` Alexey Dobriyan [this message]
2010-02-18 20:53 ` jamal
2010-02-18 21:45 ` jamal
2010-02-18 22:27 ` David Miller
2010-02-18 22:52 ` jamal
2010-02-18 23:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218185510.GA18829@x200 \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).