From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: kirjanov@gmail.com, kristoffer@gaisler.com, netdev@vger.kernel.org
Subject: Re: [PATCH] greth: some driver cleanups
Date: Fri, 19 Feb 2010 13:18:19 -0800 (PST) [thread overview]
Message-ID: <20100219.131819.27458744.davem@davemloft.net> (raw)
In-Reply-To: <20100219152502.GD6598@psychotron.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Fri, 19 Feb 2010 16:25:02 +0100
> Fri, Feb 19, 2010 at 04:00:52PM CET, kirjanov@gmail.com wrote:
>>On Fri, Feb 19, 2010 at 13:51 +0100, Jiri Pirko wrote:
>>>
>>> <snip>
>>> >>@@ -1031,7 +1029,7 @@ static void greth_set_multicast_list(struct net_device *dev)
>>> >> return;
>>> >> }
>>> >>
>>> >>- if (dev->mc_count == 0) {
>>> >>+ if (!netdev_mc_count(dev)) {
>>> also please use netdev_mc_empty() here.
>>Some driver cleanups:
>>* convert to use phy_find_first/phy_direct_connect
>>* convert to use netdev_mc_* helpers
>>* fixed missing validate_addr hook
>>* removed netdev_priv castings
>>
>>Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
...
> Looks good.
>
> Reviewed-by: Jiri Pirko <jpirko@redhat.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-02-19 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 11:14 [PATCH] greth: some driver cleanups Denis Kirjanov <kirjanov@gmail.com
2010-02-19 12:04 ` Jiri Pirko
2010-02-19 12:51 ` Jiri Pirko
2010-02-19 15:00 ` Denis Kirjanov <kirjanov@gmail.com
2010-02-19 15:25 ` Jiri Pirko
2010-02-19 21:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219.131819.27458744.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=kirjanov@gmail.com \
--cc=kristoffer@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).