From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC 1/2] sctp: convert hash list to RCU Date: Fri, 19 Feb 2010 08:18:56 -0800 Message-ID: <20100219081856.79ba7cf8@nehalam> References: <20100219055520.223027612@vyatta.com> <20100219055628.436258223@vyatta.com> <20100219155825.GA6778@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Vlad Yasevich , Sridhar Samudrala , "David S. Miller" , netdev@vger.kernel.org, linux-sctp@vger.kernel.org To: paulmck@linux.vnet.ibm.com Return-path: Received: from mail.vyatta.com ([76.74.103.46]:45768 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462Ab0BSQTW (ORCPT ); Fri, 19 Feb 2010 11:19:22 -0500 In-Reply-To: <20100219155825.GA6778@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 19 Feb 2010 07:58:25 -0800 "Paul E. McKenney" wrote: > On Thu, Feb 18, 2010 at 09:55:21PM -0800, Stephen Hemminger wrote: > > This patch converts existing SCTP hash list to using RCU > > rather than reader/writer lock. Also, get rid of no longer used > > locking wrappers. > > > > In future, the SCTP hash locking should be broken out from the > > hash structure because of the wasted space for the hash locks > > and associated holes. A single lock per hashlist is sufficient > > now that RCU is used. > > > > Compile tested only. I can't think of an SCTP stress application. > > > > P.s: Some janitor ought to go through and remove the locking > > macros here. > > One question below about what looks to be mixing of RCU and RCU-bh > read-side critical sections while waiting only for RCU grace periods. > Unless I am missing something, this can result in memory corruption. > Thanks, I copied the original locking which was broken there as well. --