From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, rusty@rustcorp.com.au,
oberpar@linux.vnet.ibm.com, mszeredi@suse.cz,
paulmck@linux.vnet.ibm.com, jpirko@redhat.com, jolsa@redhat.com,
mingo@elte.hu, adobriyan@gmail.com, hadi@cyberus.ca,
nhorman@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] af_key: locking change
Date: Sat, 20 Feb 2010 12:51:45 -0800 (PST) [thread overview]
Message-ID: <20100220.125145.173499637.davem@davemloft.net> (raw)
In-Reply-To: <20100219215314.66d6f857@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 19 Feb 2010 21:53:14 -0800
> On Sat, 20 Feb 2010 05:07:30 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le vendredi 19 février 2010 à 13:59 -0800, Stephen Hemminger a écrit :
>> > pièce jointe document texte brut (pfkey-rcu.patch)
>> > Get rid of custom locking that was using wait queue, lock, and atomic
>> > to basically build a queued mutex. Use RCU for read side.
>> >
>> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>>
>> Excellent
>>
>> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>>
>> I dont know why you used synchronize_sched() instead of
>> synchronize_rcu().
>
> I'll go back to synchronize_rcu.
Please also add some comments for patch #1 as requested by
Al Viro.
When you post the new series with these changes I'll apply
it to net-next-2.6, thanks!
next prev parent reply other threads:[~2010-02-20 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 21:59 [PATCH 0/3] Convert packet and key sockets to RCU Stephen Hemminger
2010-02-19 21:59 ` [PATCH 1/3] seq_file: add RCU versions of new hlist/list iterators (v3) Stephen Hemminger
2010-02-19 22:22 ` Al Viro
2010-02-19 21:59 ` [PATCH 2/3] packet: convert socket list to RCU (v2) Stephen Hemminger
2010-02-19 22:23 ` [PATCH] packet: convert socket list to RCU (v3) Stephen Hemminger
2010-02-20 3:39 ` Eric Dumazet
2010-02-19 21:59 ` [PATCH 3/3] af_key: locking change Stephen Hemminger
2010-02-20 4:07 ` Eric Dumazet
2010-02-20 5:53 ` Stephen Hemminger
2010-02-20 20:51 ` David Miller [this message]
[not found] <20100222175716.900955428@vyatta.com>
2010-02-22 17:57 ` Stephen Hemminger
2010-02-22 23:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220.125145.173499637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=jolsa@redhat.com \
--cc=jpirko@redhat.com \
--cc=mingo@elte.hu \
--cc=mszeredi@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=oberpar@linux.vnet.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=shemminger@vyatta.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).