From: David Miller <davem@davemloft.net>
To: rmody@brocade.com
Cc: netdev@vger.kernel.org, adapter_linux_open_src_team@brocade.com
Subject: Re: Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver
Date: Sun, 21 Feb 2010 22:39:32 -0800 (PST) [thread overview]
Message-ID: <20100221.223932.39195123.davem@davemloft.net> (raw)
In-Reply-To: <201002192152.o1JLqcB6031953@blc-10-1.brocade.com>
This driver still needs a lot of work.
The number of headers files is rediculious and I see pieces of
information duplicated up to 4 or 5 times (!?!??!)
First, reduce the header files to say two or three.
Next, remove all of the duplicated information. You have at least two
copies of the PCI device ID in these header files. There are three or
four definitions of the same statistics data structures.
It's pure bloat, you have to consolidate the content and the number of
header files holding this information.
next prev parent reply other threads:[~2010-02-22 6:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 21:52 Subject: [PATCH 0/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2010-02-20 21:01 ` David Miller
2010-02-22 6:39 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-12 14:00 Rasesh Mody
2010-02-13 0:41 ` David Miller
2010-02-10 6:29 Rasesh Mody
2009-12-19 1:28 Debashis Dutt
2009-12-19 2:02 ` Ben Hutchings
2009-12-19 3:38 ` David Miller
2009-11-26 9:28 Debashis Dutt
2009-11-24 3:51 Rasesh Mody
2009-11-17 8:57 Rasesh Mody
2009-11-17 8:30 Rasesh Mody
2009-11-17 9:03 ` David Miller
2009-11-13 3:46 Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221.223932.39195123.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adapter_linux_open_src_team@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).