From: Jiri Pirko <jpirko@redhat.com>
To: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>
Cc: netdev@vger.kernel.org
Subject: Re: RE: [net-next 2.6 PATCH] net/pcmcia: convert to use
Date: Sun, 21 Feb 2010 11:32:53 +0100 [thread overview]
Message-ID: <20100221103245.GA2584@psychotron.redhat.com> (raw)
In-Reply-To: <9571361.89671266729917620.ken_kawasaki@spring.nifty.jp>
Sun, Feb 21, 2010 at 06:25:17AM CET, ken_kawasaki@spring.nifty.jp wrote:
>Hi,
>
>"ifndef final_version" is unnecessary in smc91c92_cs.c,
>isn't it?
>
>-#ifndef final_version /* Verify multicast address. */
>- if ((mc_addr->dmi_addr[0] & 1) == 0)
>- continue;
>-#endif
Right, looks like it is. Feel free to send the patch to remove this.
Jirka
>
>
>Ken
>
next prev parent reply other threads:[~2010-02-21 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5083689.85171266728689181.ken_kawasaki@spring.nifty.jp>
2010-02-21 5:25 ` RE: [net-next 2.6 PATCH] net/pcmcia: convert to use Ken Kawasaki
2010-02-21 10:32 ` Jiri Pirko [this message]
2010-02-21 6:57 ` Ken Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100221103245.GA2584@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox