* Re: RE: [net-next 2.6 PATCH] net/pcmcia: convert to use
[not found] <5083689.85171266728689181.ken_kawasaki@spring.nifty.jp>
@ 2010-02-21 5:25 ` Ken Kawasaki
2010-02-21 10:32 ` Jiri Pirko
2010-02-21 6:57 ` Ken Kawasaki
1 sibling, 1 reply; 3+ messages in thread
From: Ken Kawasaki @ 2010-02-21 5:25 UTC (permalink / raw)
To: netdev; +Cc: jpirko
Hi,
"ifndef final_version" is unnecessary in smc91c92_cs.c,
isn't it?
-#ifndef final_version /* Verify multicast address. */
- if ((mc_addr->dmi_addr[0] & 1) == 0)
- continue;
-#endif
Ken
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RE: [net-next 2.6 PATCH] net/pcmcia: convert to use
[not found] <5083689.85171266728689181.ken_kawasaki@spring.nifty.jp>
2010-02-21 5:25 ` RE: [net-next 2.6 PATCH] net/pcmcia: convert to use Ken Kawasaki
@ 2010-02-21 6:57 ` Ken Kawasaki
1 sibling, 0 replies; 3+ messages in thread
From: Ken Kawasaki @ 2010-02-21 6:57 UTC (permalink / raw)
To: netdev
Hi,
sorry, ioaddr is used by PutByte macro.
>
>ioaddr is not used in set_address of xirc2ps_cs.c
>
>
>+static void set_address(struct set_address_info *sa_info, char *addr)
>+{
>+ unsigned int ioaddr = sa_info->ioaddr; <== HERE
>+ int i;
>+
>+ for (i = 0; i < 6; i++) {
>+ if (sa_info->reg_nr > 15) {
>+ sa_info->reg_nr = 8;
>+ sa_info->page_nr++;
>+ SelectPage(sa_info->page_nr);
>+ }
>+ if (sa_info->mohawk)
>+ PutByte(sa_info->reg_nr++, addr[5 - i]);
>+ else
>+ PutByte(sa_info->reg_nr++, addr[i]);
>+ }
>+}
>+
Ken
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RE: [net-next 2.6 PATCH] net/pcmcia: convert to use
2010-02-21 5:25 ` RE: [net-next 2.6 PATCH] net/pcmcia: convert to use Ken Kawasaki
@ 2010-02-21 10:32 ` Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2010-02-21 10:32 UTC (permalink / raw)
To: Ken Kawasaki; +Cc: netdev
Sun, Feb 21, 2010 at 06:25:17AM CET, ken_kawasaki@spring.nifty.jp wrote:
>Hi,
>
>"ifndef final_version" is unnecessary in smc91c92_cs.c,
>isn't it?
>
>-#ifndef final_version /* Verify multicast address. */
>- if ((mc_addr->dmi_addr[0] & 1) == 0)
>- continue;
>-#endif
Right, looks like it is. Feel free to send the patch to remove this.
Jirka
>
>
>Ken
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-21 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5083689.85171266728689181.ken_kawasaki@spring.nifty.jp>
2010-02-21 5:25 ` RE: [net-next 2.6 PATCH] net/pcmcia: convert to use Ken Kawasaki
2010-02-21 10:32 ` Jiri Pirko
2010-02-21 6:57 ` Ken Kawasaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox