Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Fri, Feb 19, 2010 at 01:52:38PM -0800, Rasesh Mody wrote:
> From: Rasesh Mody <rmody@brocade.com>
> 
> This is patch 1/6 which contains linux driver source for
> Brocade's BR1010/BR1020 10Gb CEE capable ethernet adapter.
> Source is based against net-next-2.6.
> 
> We wish this patch to be considered for inclusion in net-next-2.6
> 
> Signed-off-by: Rasesh Mody <rmody@brocade.com>
> ---
>  bnad.c | 3481 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  bnad.h |  341 ++++++
>  2 files changed, 3822 insertions(+)
[snip]
> void bnad_ioc_timeout(unsigned long ioc_arg)
> +{
> +	struct bnad *bnad = (struct bnad *)(((struct bfa_ioc*)ioc_arg)->bfa);
> +	spin_lock_irq(&bnad->priv_lock);
> +	spin_unlock_irq(&bnad->priv_lock);

Quite strange spin lock usage :)
  
> +u32
> +bnad_get_msglevel(struct net_device *netdev)
> +{
> +	return bnad_log_level;
> +}
> +
> +void
> +bnad_set_msglevel(struct net_device *netdev, u32 msglevel)
> +{
> +	struct bnad *bnad = netdev_priv(netdev);
> +	mutex_lock(&bnad->conf_mutex);
> +	bnad_log_level = msglevel;
> +	mutex_unlock(&bnad->conf_mutex);
> +}

bnad_log_level is not used anywhere.