From: David Miller <davem@davemloft.net>
To: anemo@mba.ocn.ne.jp
Cc: netdev@vger.kernel.org, ralf.roesch@rw-gmbh.de
Subject: Re: [PATCH] tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON
Date: Tue, 23 Feb 2010 01:26:14 -0800 (PST) [thread overview]
Message-ID: <20100223.012614.109539080.davem@davemloft.net> (raw)
In-Reply-To: <20100220.003122.26280041.anemo@mba.ocn.ne.jp>
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 20 Feb 2010 00:31:22 +0900 (JST)
> On Sat, 20 Feb 2010 00:13:58 +0900, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>> @@ -1437,7 +1437,6 @@ static int tc35815_do_interrupt(struct net_device *dev, u32 status, int limit)
>> /* Transmit complete. */
>> lp->lstats.tx_ints++;
>> tc35815_txdone(dev);
>> - netif_wake_queue(dev);
>> if (ret < 0)
>> ret = 0;
>> }
>
> BTY, it looks isa-skelton.c have same problem.
...
> I suppose here is the far origin of the bug :)
Please send a patch for this.
Thank you.
next prev parent reply other threads:[~2010-02-23 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 15:13 [PATCH] tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON Atsushi Nemoto
2010-02-19 15:31 ` Atsushi Nemoto
2010-02-23 9:26 ` David Miller [this message]
2010-02-23 9:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223.012614.109539080.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anemo@mba.ocn.ne.jp \
--cc=netdev@vger.kernel.org \
--cc=ralf.roesch@rw-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).