From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/7] cxgb4 patches V2
Date: Tue, 23 Feb 2010 14:40:54 -0800 (PST) [thread overview]
Message-ID: <20100223.144054.261850790.davem@davemloft.net> (raw)
In-Reply-To: <4B842771.9000506@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Tue, 23 Feb 2010 11:07:29 -0800
> Can you please clarify what exactly you want me to change about the
> macros? I looked at a few other drivers in the tree and I saw shift
> macros with _SHIFT or _SH suffixes, masks tend to have _MASK or _MSK
> suffixes, etc. Are you asking me basically to change our S_, V_, etc
> prefixes to _SHIFT, etc suffixes or are we talking about some other
> kind of change? Please bear with me, I am trying to understand what
> you're asking for exactly.
Yes. Don't put things at the beginning, start with the register
name then add things at the end for shifts, masks, etc.
prev parent reply other threads:[~2010-02-23 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 21:24 [PATCH net-next 0/7] cxgb4 patches V2 Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 1/7] cxgb4: Add register and message definitions Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 2/7] cxgb4: Add FW API definitions Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 3/7] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 4/7] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 5/7] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 6/7] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
2010-02-18 21:24 ` [PATCH net-next 7/7] net: Hook up cxgb4 to Kconfig and Makefile Dimitris Michailidis
2010-02-22 6:30 ` [PATCH net-next 0/7] cxgb4 patches V2 David Miller
2010-02-23 19:07 ` Dimitris Michailidis
2010-02-23 22:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223.144054.261850790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).