* [net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr
@ 2010-02-23 19:54 Jiri Pirko
2010-02-26 9:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2010-02-23 19:54 UTC (permalink / raw)
To: netdev; +Cc: davem
Hmm so actually my original patch including this bit was correct,
"list = list->next;" confused me :) - will send patch correcting that in a few.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
---
drivers/net/octeon/octeon_mgmt.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/net/octeon/octeon_mgmt.c b/drivers/net/octeon/octeon_mgmt.c
index 3a0f910..be368e5 100644
--- a/drivers/net/octeon/octeon_mgmt.c
+++ b/drivers/net/octeon/octeon_mgmt.c
@@ -467,7 +467,6 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
{
struct octeon_mgmt *p = netdev_priv(netdev);
int port = p->port;
- int i;
union cvmx_agl_gmx_rxx_adr_ctl adr_ctl;
union cvmx_agl_gmx_prtx_cfg agl_gmx_prtx;
unsigned long flags;
@@ -511,12 +510,8 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
}
}
if (multicast_mode == 0) {
- i = netdev_mc_count(netdev);
- list = netdev->mc_list;
- while (i--) {
+ netdev_for_each_mc_addr(list, netdev)
octeon_mgmt_cam_state_add(&cam_state, list->da_addr);
- list = list->next;
- }
}
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr
2010-02-23 19:54 [net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr Jiri Pirko
@ 2010-02-26 9:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-02-26 9:50 UTC (permalink / raw)
To: jpirko; +Cc: netdev
From: Jiri Pirko <jpirko@redhat.com>
Date: Tue, 23 Feb 2010 20:54:58 +0100
> Hmm so actually my original patch including this bit was correct,
> "list = list->next;" confused me :) - will send patch correcting that in a few.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-26 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-23 19:54 [net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr Jiri Pirko
2010-02-26 9:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).