From: David Miller <davem@davemloft.net>
To: sgruszka@redhat.com
Cc: netdev@vger.kernel.org, vladz@broadcom.com, eilong@broadcom.com,
dhowells@redhat.com
Subject: Re: [RFC PATCH] bnx2x: fix tx queue locking and memory barriers
Date: Thu, 25 Feb 2010 02:18:22 -0800 (PST) [thread overview]
Message-ID: <20100225.021822.66777947.davem@davemloft.net> (raw)
In-Reply-To: <20100225140834.0169e9f2@dhcp-lab-109.englab.brq.redhat.com>
From: Stanislaw Gruszka <sgruszka@redhat.com>
Date: Thu, 25 Feb 2010 14:08:34 +0100
> Memory barriers here IMHO, prevent to make queue permanently stopped
> when on one cpu bnx2x_tx_int() make queue empty, whereas on other
> cpu bnx2x_start_xmit() see it full and make stop it, such cause
> queue will be stopped forever.
Instead of having an opinion, please show the exact sequence
of events that can lead to this situation. With such facts
inhand, you will have no need for an opinion :-)
next prev parent reply other threads:[~2010-02-25 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 13:08 [RFC PATCH] bnx2x: fix tx queue locking and memory barriers Stanislaw Gruszka
2010-02-25 10:18 ` David Miller [this message]
2010-02-25 15:40 ` Stanislaw Gruszka
2010-02-25 15:49 ` Vladislav Zolotarov
2010-02-25 16:03 ` Stanislaw Gruszka
2010-02-25 16:06 ` David Miller
2010-02-25 16:16 ` Stanislaw Gruszka
2010-02-25 16:14 ` Vladislav Zolotarov
2010-02-25 13:28 ` Vladislav Zolotarov
2010-03-10 17:09 ` David Howells
2010-03-10 17:49 ` David Miller
2010-03-10 18:32 ` David Howells
2010-03-11 13:10 ` Stanislaw Gruszka
2010-03-10 17:19 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225.021822.66777947.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).