From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: marcel@holtmann.org, netdev@vger.kernel.org,
daniel.martensson@stericsson.com, kaber@trash.net,
stefano.babic@babic.homelinux.org, randy.dunlap@oracle.com
Subject: Re: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack
Date: Fri, 26 Feb 2010 01:22:04 -0800 (PST) [thread overview]
Message-ID: <20100226.012204.67216627.davem@davemloft.net> (raw)
In-Reply-To: <61D8D34BB13CFE408D154529C120E07903359AE7@eseldmw101.eemea.ericsson.se>
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Tue, 23 Feb 2010 08:39:52 +0100
> Hi Marcel.
>>> CHANGE LOG:
>>> Based on review comments from David Miller and Marcel Holtmann on the
>>> previous patch set submitted the 16 February the following changes
>>> have been done:
>>> - Removed ifdef __cplusplus from caif_socket.h
>>> - Use socket level SOL_IP for socket options SO_PRIORITY and
>>> SO_BINDTODEVICE
>>
>> are you sure it is not better to use SOL_SOCKET here. At least
>> according to man 7 socket this would make a lot more sense. My point
>> in actually using SO_PRIORITY and SO_BINDTODEVICE is to use standard
>> socket options that are already used by everybody else. So they know
>> what to expect.
>>
> Yes, this makes sense. I'll update this.
Please fix this up and resubmit your patch series so I can add
it to the net-next-2.6 tree.
next prev parent reply other threads:[~2010-02-26 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 22:05 [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 01/12] net-caif: add CAIF protocol definitions sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 02/12] net-caif: add CAIF socket and configuration headers sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 03/12] net-caif: add CAIF core protocol stack header files sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 04/12] net-caif: add CAIF Link layer device " sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 05/12] net-caif: add CAIF core protocol stack sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 06/12] net-caif: add CAIF generic caif support functions sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 07/12] net-caif: add CAIF device registration functionality sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 08/12] net-caif: add CAIF socket implementation sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 09/12] net-caif: add CAIF netdevice sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 10/12] net-caif: add CAIF Kconfig and Makefiles sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 11/12] net-caif: add CAIF documentation sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 12/12] net-caif-driver: add CAIF serial driver (ldisc) sjur.brandeland
2010-02-23 7:33 ` [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack Marcel Holtmann
2010-02-23 7:39 ` Sjur Brændeland
2010-02-26 9:22 ` David Miller [this message]
2010-02-27 10:05 ` Sjur Brændeland
2010-02-27 10:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226.012204.67216627.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.martensson@stericsson.com \
--cc=kaber@trash.net \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sjur.brandeland@stericsson.com \
--cc=stefano.babic@babic.homelinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).