[net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr

[net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr

[Jiri Pirko]

Hmm so actually my original patch including this bit was correct,
"list = list->next;" confused me :) - will send patch correcting that in a few.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
---
 drivers/net/octeon/octeon_mgmt.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/drivers/net/octeon/octeon_mgmt.c b/drivers/net/octeon/octeon_mgmt.c
index 3a0f910..be368e5 100644
--- a/drivers/net/octeon/octeon_mgmt.c
+++ b/drivers/net/octeon/octeon_mgmt.c
@@ -467,7 +467,6 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
 {
 	struct octeon_mgmt *p = netdev_priv(netdev);
 	int port = p->port;
-	int i;
 	union cvmx_agl_gmx_rxx_adr_ctl adr_ctl;
 	union cvmx_agl_gmx_prtx_cfg agl_gmx_prtx;
 	unsigned long flags;
@@ -511,12 +510,8 @@ static void octeon_mgmt_set_rx_filtering(struct net_device *netdev)
 		}
 	}
 	if (multicast_mode == 0) {
-		i = netdev_mc_count(netdev);
-		list = netdev->mc_list;
-		while (i--) {
+		netdev_for_each_mc_addr(list, netdev)
 			octeon_mgmt_cam_state_add(&cam_state, list->da_addr);
-			list = list->next;
-		}
 	}
 
 
-- 
1.6.6

Re: [net-next-2.6 PATCH] octeon: convert to use netdev_for_each_mc_addr

[David Miller]

From: Jiri Pirko <jpirko@redhat.com>
Date: Tue, 23 Feb 2010 20:54:58 +0100

> Hmm so actually my original patch including this bit was correct,
> "list = list->next;" confused me :) - will send patch correcting that in a few.
> 
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>

Applied.