netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sysoleg@yandex.ru
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices
Date: Fri, 26 Feb 2010 05:50:25 -0800 (PST)	[thread overview]
Message-ID: <20100226.055025.30718012.davem@davemloft.net> (raw)
In-Reply-To: <68631266953760@webmail134.yandex.ru>

From: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
Date: Tue, 23 Feb 2010 22:36:00 +0300

> 23.02.10, 15:59, "Ben Hutchings" <bhutchings@solarflare.com>:
> 
>>  The queue mapping will normally be the same, only no longer biased by 1.
>>  So I think a better solution would be to maintain that bias on TX as
>>  well, or to remove the bias and reserve -1 for unknown RX queue.
> 
> Second try. Not tested but looks OK.
> 
> Must be applied with "[net-next-2.6 PATCH] Multiqueue support for bonding devices"
> 
> Forwarded packet goes through dev_queue_xmit() more that once when using bonding
> or 802.1q VLAN devices, so we've lost rx-tx queue mapping index for real devices.
> This is because initial queue index value (as it recorded by skb_record_tx_queue())
> is overwritten by skb_set_queue_mapping().
> 
> Signed-off-by: Oleg A. Arkhangelsky <sysoleg@yandex.ru> 

Your patches are fine, but they are whitespace corrupted by your
email client (tabs turned into spaces, etc.) so they won't apply
properly.

Please fix this up and resend your patches.

Thanks!

  parent reply	other threads:[~2010-02-26 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-23 15:17 [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices "Oleg A. Arkhangelsky"
2010-02-23 15:59 ` Ben Hutchings
2010-02-23 19:36   ` "Oleg A. Arkhangelsky"
2010-02-24  9:53     ` Jeff Kirsher
2010-02-26 13:50     ` David Miller [this message]
2010-02-27  9:53       ` "Oleg A. Arkhangelsky"
2010-02-27 10:02         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226.055025.30718012.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=sysoleg@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).