From: Jiri Pirko <jpirko@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] net: convert multiple drivers to use netdev_for_each_mc_addr, part5 V2
Date: Fri, 26 Feb 2010 11:12:25 +0100 [thread overview]
Message-ID: <20100226101224.GC2650@psychotron.redhat.com> (raw)
In-Reply-To: <20100226.020333.13570565.davem@davemloft.net>
Fri, Feb 26, 2010 at 11:03:33AM CET, davem@davemloft.net wrote:
>
>100 EURO says you didn't compile test this.
>
>@@ -975,7 +968,7 @@ static void do_set_multicast_list(struct net_device *dev)
>
> if(dev->flags&IFF_PROMISC)
> ei_outb_p(E8390_RXCONFIG | 0x18, e8390_base + EN0_RXCR);
>- else if(dev->flags&IFF_ALLMULTI || dev->mc_list)
>+ else if (dev->flags & IFF_ALLMULTI || !netdev_mc_addr(dev))
> ei_outb_p(E8390_RXCONFIG | 0x08, e8390_base + EN0_RXCR);
> else
> ei_outb_p(E8390_RXCONFIG, e8390_base + EN0_RXCR);
>
>I'll fix it up, but you have to start getting proper build
>coverage of your patches!
>
>I really don't care how slow your netbook is, this case could have
>been easily prevented.
I'm really sorry, I do compile test all my patches, but I must have missed this
:(
I promise I'll reserve 2xtime next time. You'll have a beer on me :)
Jirka
prev parent reply other threads:[~2010-02-26 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 19:19 [net-next-2.6 PATCH] net: convert multiple drivers to use netdev_for_each_mc_addr, part5 V2 Jiri Pirko
2010-02-26 9:49 ` David Miller
2010-02-26 10:03 ` David Miller
2010-02-26 10:12 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226101224.GC2650@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).