From: David Miller <davem@davemloft.net>
To: nbd@openwrt.org
Cc: ddaney@caviumnetworks.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, buytenh@wantstofly.org
Subject: Re: [PATCH v3] skbuff: align sk_buff::cb to 64 bit and close some potential holes
Date: Sat, 27 Feb 2010 03:17:27 -0800 (PST) [thread overview]
Message-ID: <20100227.031727.143841315.davem@davemloft.net> (raw)
In-Reply-To: <4B844C8F.2060908@openwrt.org>
From: Felix Fietkau <nbd@openwrt.org>
Date: Tue, 23 Feb 2010 22:45:51 +0100
> The alignment requirement for 64-bit load/store instructions on ARM is
> implementation defined. Some CPUs (such as Marvell Feroceon) do not
> generate an exception, if such an instruction is executed with an
> address that is not 64 bit aligned. In such a case, the Feroceon
> corrupts adjacent memory, which showed up in my tests as a crash in the
> rx path of ath9k that only occured with CONFIG_XFRM set.
>
> This crash happened, because the first field of the mac80211 rx status
> info in the cb is an u64, and changing it corrupted the skb->sp field.
>
> This patch also closes some potential pre-existing holes in the sk_buff
> struct surrounding the cb[] area.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Cc: stable@kernel.org
Applied, thanks for following up on this Felix.
prev parent reply other threads:[~2010-02-27 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 0:38 [PATCH v2] skbuff: align sk_buff::cb to 64 bit Felix Fietkau
2010-01-30 7:07 ` Eric Dumazet
2010-02-01 18:26 ` David Daney
2010-02-01 18:37 ` Felix Fietkau
2010-02-12 20:13 ` David Miller
2010-02-23 21:45 ` [PATCH v3] skbuff: align sk_buff::cb to 64 bit and close some potential holes Felix Fietkau
2010-02-27 11:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227.031727.143841315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=ddaney@caviumnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).