Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: yamato@redhat.com, netdev@vger.kernel.org
Subject: Re: Adding inode field to /proc/net/netlink
Date: Sun, 28 Feb 2010 01:28:34 -0800 (PST)	[thread overview]
Message-ID: <20100228.012834.15245196.davem@davemloft.net> (raw)
In-Reply-To: <1267348431.9082.66.camel@edumazet-laptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 28 Feb 2010 10:13:51 +0100

> Hmm we already did such expansion last year with commit 38938bfe when
> Pablo Neira Ayuso added the Drops column
> 
> Extract of its Changelog :
> 
>  This patch also includes the use of sk_drop to account the number of
>  netlink messages drop due to overrun. This value is shown in
>  /proc/net/netlink.
> 
> So yes, some applications might break but they probably already broke
> one year ago and their maintainers should know that adding new fields at
> the end of lines is expected ?
> 
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

That's a good point.

Ok, I'll apply this.

Thanks.

  reply	other threads:[~2010-02-28  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-28  5:45 Adding inode field to /proc/net/netlink Masatake YAMATO
2010-02-28  9:00 ` David Miller
2010-02-28  9:13   ` Eric Dumazet
2010-02-28  9:28     ` David Miller [this message]
2010-02-28  9:50   ` Masatake YAMATO
2010-02-28  9:44     ` Eric Dumazet
2010-02-28 12:44       ` Masatake YAMATO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100228.012834.15245196.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=yamato@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox