From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: do not set some flags, if others failed
Date: Sun, 28 Feb 2010 01:40:47 -0800 (PST) [thread overview]
Message-ID: <20100228.014047.212690802.davem@davemloft.net> (raw)
In-Reply-To: <20100227074338.GA17322@havoc.gtf.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Sat, 27 Feb 2010 02:43:38 -0500
>
> NETIF_F_NTUPLE flag setting introduced a bug: non-ntuple flags
> like LRO may be successfully set, before ioctl(2) returns failure
> to userspace.
>
> The set-flags operation should be all-or-none, rather than leaving
> things in an inconsistent state prior to reporting failure to
> userspace.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Applied, thanks Jeff.
prev parent reply other threads:[~2010-02-28 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 7:43 [PATCH] ethtool: do not set some flags, if others failed Jeff Garzik
2010-02-28 9:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228.014047.212690802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).