From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/7] cxgb4: driver submission V4
Date: Sun, 28 Feb 2010 18:59:47 -0800 (PST) [thread overview]
Message-ID: <20100228.185947.88334097.davem@davemloft.net> (raw)
In-Reply-To: <20100228.183000.161196735.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 28 Feb 2010 18:30:00 -0800 (PST)
> From: Dimitris Michailidis <dm@chelsio.com>
> Date: Sun, 28 Feb 2010 08:09:38 -0800
>
>>
>> This is V4 of the cxgb4 patches, which is V3 with need_skb_unmap removed.
>
> Applied.
Nevermind, reverted.
You're not build testing your changes either:
drivers/net/cxgb4/cxgb4_main.c: In function 'cxgb_netpoll':
drivers/net/cxgb4/cxgb4_main.c:3470: warning: pointer type mismatch in conditional expression
drivers/net/cxgb4/cxgb4_main.c:3470: warning: passing argument 1 of 't4_intr_handler(adap)' makes integer from pointer without a cast
drivers/net/cxgb4/cxgb4_main.c:3470: note: expected 'int' but argument is of type 'void *'
drivers/net/cxgb4/cxgb4_main.c:3470: error: too few arguments to function 't4_intr_handler(adap)'
make[3]: *** [drivers/net/cxgb4/cxgb4_main.o] Error 1
make[3]: *** Waiting for unfinished jobs....
You know, I really can't believe people not only bomb me with all of
this last minute networking crap, but on top of it they are also doing
so with such poorly tested changes.
Stuff that doesn't even friggin' build!
prev parent reply other threads:[~2010-03-01 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 16:09 [PATCH 0/7] cxgb4: driver submission V4 Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 1/7] cxgb4: Add register and message definitions Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 2/7] cxgb4: Add FW API definitions Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 3/7] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 4/7] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 5/7] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 6/7] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
2010-02-28 16:09 ` [PATCH 7/7] net: Hook up cxgb4 to Kconfig and Makefile Dimitris Michailidis
2010-03-01 2:30 ` [PATCH 0/7] cxgb4: driver submission V4 David Miller
2010-03-01 2:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228.185947.88334097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).