From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: sri@us.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] bridge: Fix build error when IGMP_SNOOPING is not enabled
Date: Mon, 01 Mar 2010 18:14:32 -0800 (PST) [thread overview]
Message-ID: <20100301.181432.04478860.davem@davemloft.net> (raw)
In-Reply-To: <20100302004626.GA28274@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 2 Mar 2010 08:46:26 +0800
> On Mon, Mar 01, 2010 at 11:53:04AM -0800, Sridhar Samudrala wrote:
>> Fix the following build error when IGMP_SNOOPING is not enabled.
>> In file included from net/bridge/br.c:24:
>> net/bridge/br_private.h: In function 'br_multicast_is_router':
>> net/bridge/br_private.h:361: error: 'struct net_bridge' has no member named 'multicast_router'
>> net/bridge/br_private.h:362: error: 'struct net_bridge' has no member named 'multicast_router'
>> net/bridge/br_private.h:363: error: 'struct net_bridge' has no member named 'multicast_router_timer'
>>
>> Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
>
> Thanks for the fix.
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> I'd originally left the struct data outside ifdefs and then added
> the ifdefs without testing.
Thanks everyone, I'll apply this.
prev parent reply other threads:[~2010-03-02 2:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 19:53 [PATCH net-next-2.6] bridge: Fix build error when IGMP_SNOOPING is not enabled Sridhar Samudrala
2010-03-01 20:54 ` Randy Dunlap
2010-03-02 0:46 ` Herbert Xu
2010-03-02 2:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301.181432.04478860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).