From: David Miller <davem@davemloft.net>
To: stefanr@s5r6.in-berlin.de
Cc: eric.dumazet@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: sparse checking prevented by "net: fix kmemcheck annotations"
Date: Mon, 01 Mar 2010 18:39:55 -0800 (PST) [thread overview]
Message-ID: <20100301.183955.258219526.davem@davemloft.net> (raw)
In-Reply-To: <4B8BE8BE.9070505@s5r6.in-berlin.de>
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Mon, 01 Mar 2010 17:18:06 +0100
> Eric Dumazet wrote:
>> [PATCH] net: fix protocol sk_buff field
>>
>> Commit e992cd9b72a18 (kmemcheck: make bitfield annotations truly no-ops
>> when disabled) allows us to revert a workaround we did in the past to
>> not add holes in sk_buff structure.
>>
>> This patch partially reverts commit 14d18a81b5171
>> (net: fix kmemcheck annotations) so that sparse doesnt complain:
>>
>> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
>> type restricted __be16.
>
> Great, very appreciated.
Applied, thanks everyone.
prev parent reply other threads:[~2010-03-02 2:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 12:09 sparse checking prevented by "net: fix kmemcheck annotations" Stefan Richter
2010-03-01 13:09 ` Eric Dumazet
2010-03-01 16:18 ` Stefan Richter
2010-03-02 2:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301.183955.258219526.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).