From: David Miller <davem@davemloft.net>
To: sathyap@serverengines.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] be2net: fix tx completion polling
Date: Tue, 02 Mar 2010 03:56:49 -0800 (PST) [thread overview]
Message-ID: <20100302.035649.53340739.davem@davemloft.net> (raw)
In-Reply-To: <20100302063615.GA6480@serverengines.com>
From: Sathya Perla <sathyap@serverengines.com>
Date: Tue, 2 Mar 2010 12:06:15 +0530
> On 26/02/10 04:19 -0800, David Miller wrote:
>> From: Sathya Perla <sathyap@serverengines.com>
>> Date: Thu, 25 Feb 2010 17:25:16 +0530
>>
>> > In tx/mcc polling, napi_complete() is being incorrectly called
>> > before reaping tx completions. This can cause tx compl processing
>> > to be scheduled on another cpu concurrently which can result in a panic.
>> > This if fixed by calling napi complete() after tx/mcc compl processing
>> > but before re-enabling interrupts (via a cq notify).
>> >
>> > Pls apply to net-2.6.
>>
>> net-2.6 is closed, 2.6.33 has been released.
>>
>> > Signed-off-by: Sathya Perla <sathyap@serverengines.com>
>>
>> This patch does not apply to net-next-2.6
>
> I've re-done the patch for net-next-2.6: Pls apply; thanks!
>
> In tx/mcc polling, napi_complete() is being incorrectly called
> before reaping tx completions. This can cause tx compl processing
> to be scheduled on another cpu concurrently which can result in a panic.
> This if fixed by calling napi complete() after tx/mcc compl processing
> but before re-enabling interrupts (via a cq notify).
>
> Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Applied thanks.
prev parent reply other threads:[~2010-03-02 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 11:55 [PATCH] be2net: fix tx completion polling Sathya Perla
2010-02-26 12:19 ` David Miller
2010-03-02 6:36 ` Sathya Perla
2010-03-02 11:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302.035649.53340739.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathyap@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).