From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
kaber@trash.net, yoshfuji@linux-ipv6.org, nakam@linux-ipv6.org,
eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH]xfrm: fix perpetual bundles
Date: Tue, 02 Mar 2010 06:06:06 -0800 (PST) [thread overview]
Message-ID: <20100302.060606.73203093.davem@davemloft.net> (raw)
In-Reply-To: <1267538070.21749.27.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Tue, 02 Mar 2010 08:54:30 -0500
> On Tue, 2010-03-02 at 14:46 +0100, Steffen Klassert wrote:
>
>> The problem was spotted by
>> commit a33bc5c15154c835aae26f16e6a3a7d9ad4acb45
>> xfrm: select sane defaults for xfrm[4|6] gc_thresh
>>
>> Before this commit, the xfrm garbage collector started to remove
>> stale bundle entries as soon as we reached an amount of 1024
>> bundle entries. Now the default value for the gc_thresh is
>> based on the main route table hash size, so we can have much more
>> bundle entries.
>
> yikes. Ok. Seems this fix needs to go -stable as well then.
Jamal please do some testing then I'll push Herbert's fix around.
next prev parent reply other threads:[~2010-03-02 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 13:19 [RFC PATCH]xfrm: fix perpetual bundles jamal
2010-02-25 10:40 ` Steffen Klassert
2010-02-25 13:19 ` jamal
2010-02-28 14:07 ` jamal
2010-03-01 15:33 ` Steffen Klassert
2010-03-02 11:27 ` Herbert Xu
2010-03-02 12:11 ` jamal
2010-03-02 12:51 ` Herbert Xu
2010-03-02 13:10 ` jamal
2010-03-02 13:46 ` Steffen Klassert
2010-03-02 13:54 ` jamal
2010-03-02 14:06 ` David Miller [this message]
2010-03-02 14:16 ` jamal
2010-03-02 14:06 ` Steffen Klassert
2010-03-03 0:47 ` jamal
2010-03-03 9:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302.060606.73203093.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=nakam@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).