From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Vladislav Zolotarov <vladz@broadcom.com>
Cc: Michael Chan <mchan@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Eilon Greenstein <eilong@broadcom.com>,
Matthew Carlson <mcarlson@broadcom.com>
Subject: Re: [PATCH 1/1] bnx2x: Tx barriers and locks
Date: Tue, 2 Mar 2010 12:38:01 +0100 [thread overview]
Message-ID: <20100302113800.GB2362@dhcp-lab-161.englab.brq.redhat.com> (raw)
In-Reply-To: <8628FE4E7912BF47A96AE7DD7BAC0AADCB46A2B3FE@SJEXCHCCR02.corp.ad.broadcom.com>
On Tue, Mar 02, 2010 at 02:38:39AM -0800, Vladislav Zolotarov wrote:
> After reading a Pentium Developers Manual I'm afraid I might have assumed wrong and there is needed a read memory barrier to ensure that the bit testing is performed not earlier the specified location in the code flow (due to CPU reordering).
Linux supports more relaxed cpu's than Pentium :)
> Dave, as an author of atomic_ops.txt paper I think u r the best man to ask. Could u pls. clarify that if we need to ensure that the bit testing is needed AFTER the consumer update (namely after the smp_wmb()) I need to replace it with the smp_mb().
>
> If yes, it's a clear bug and I'll prepare an appropriate patch immediately.
Yes, it's a bug.
Thanks
Stanislaw
next prev parent reply other threads:[~2010-03-02 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 10:12 [PATCH 1/1] bnx2x: Tx barriers and locks Vladislav Zolotarov
2010-03-01 2:49 ` David Miller
2010-03-01 13:33 ` Stanislaw Gruszka
2010-03-01 17:59 ` Michael Chan
2010-03-02 10:38 ` Vladislav Zolotarov
2010-03-02 11:38 ` Stanislaw Gruszka [this message]
2010-03-02 11:30 ` Stanislaw Gruszka
2010-03-02 12:50 ` Vladislav Zolotarov
2010-03-02 13:55 ` Stanislaw Gruszka
2010-03-02 16:18 ` Michael Chan
2010-03-02 16:59 ` Stanislaw Gruszka
2010-03-02 17:26 ` Michael Chan
2010-03-08 15:38 ` Stanislaw Gruszka
2010-03-02 16:21 ` Vladislav Zolotarov
-- strict thread matches above, loose matches on Subject: below --
2010-02-28 10:03 Vladislav Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302113800.GB2362@dhcp-lab-161.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).