From: Jiri Pirko <jpirko@redhat.com>
To: Pavel Roskin <proski@gnu.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]
Date: Wed, 3 Mar 2010 08:36:03 +0100 [thread overview]
Message-ID: <20100303073603.GD2648@psychotron.redhat.com> (raw)
In-Reply-To: <20100303020110.hhu4cdecg08kkck0-cebfxv@webmail.spamcop.net>
Wed, Mar 03, 2010 at 08:01:10AM CET, proski@gnu.org wrote:
>Quoting Jiri Pirko <jpirko@redhat.com>:
>
>>@@ -1734,7 +1738,7 @@ static int packet_mc_add(struct sock *sk,
>>struct packet_mreq_max *mreq)
>> goto done;
>>
>> err = -EINVAL;
>>- if (mreq->mr_alen != dev->addr_len)
>>+ if (mreq->mr_alen > dev->addr_len)
>> goto done;
>>
>> err = -ENOBUFS;
>
>The patch looks good, but did you mean to include this change? It's
>not described.
Sure - this is revert of the bit from my original patch. I think it's clear from
description.
Jirka
>
>--
>Regards,
>Pavel Roskin
next prev parent reply other threads:[~2010-03-03 7:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 1:00 Current wireless-testing breaks libpcap: mr_alen should be set Pavel Roskin
2010-03-03 2:36 ` John W. Linville
2010-03-03 6:24 ` Jiri Pirko
2010-03-03 6:57 ` Pavel Roskin
2010-03-03 6:40 ` [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko
[not found] ` <20100303064001.GB2648-YzwxZg+R7et1/kRsl7OVgNvLeJWuRmrY@public.gmane.org>
2010-03-03 6:57 ` Eric Dumazet
2010-03-03 9:05 ` Jiri Pirko
[not found] ` <20100303090512.GB2961-YzwxZg+R7evMbnheQZGK0N5OCZ2W11yPFxja6HXR22MAvxtiuMwx3w@public.gmane.org>
2010-03-03 9:06 ` David Miller
2010-03-03 9:06 ` David Miller
2010-03-03 7:01 ` Pavel Roskin
2010-03-03 7:36 ` Jiri Pirko [this message]
2010-03-03 15:31 ` Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller
2010-03-03 15:54 ` [tcpdump-workers] " Jiri Pirko
2010-03-06 21:23 ` Guy Harris
2010-03-08 8:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303073603.GD2648@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).