From: Andrew Morton <akpm@linux-foundation.org>
To: M G Berberich <berberic@fmi.uni-passau.de>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org,
"Linux Kernel Network Developers" <netdev@vger.kernel.org>
Subject: Re: 2.6.33 dies on modprobe
Date: Wed, 3 Mar 2010 14:24:20 -0800 [thread overview]
Message-ID: <20100303142420.accf985e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100303221602.GA3264@invalid>
On Wed, 3 Mar 2010 23:16:02 +0100
M G Berberich <berberic@fmi.uni-passau.de> wrote:
> Hello,
>
> Am Dienstag, den 02. M__rz schrieb Andrew Morton:
>
> > It could be that some kobject on that list has become invalid (memory
> > was freed, module was unloaded, etc) and later code stumbled across the
> > now-invalid object on that list and then crashed.
> >
> > What we can do to find this is to add a diagnostic each time an object
> > is registered, and a diagnostic each time kset_find_obj() looks at the
> > objects. Then we'll see which kobject caused the crash, then we can
> > look back and see where that kobject was registered from.
>
> [...]
>
> > This will generate a lot of output and we don't want to lose any of it.
> > I'd suggest setting up netconsole so all the output can be reliably
> > saved: Documentation/networking/netconsole.txt
>
> I have a serial connection to a netbook. Log attached.
drat, my patch didn't work. Can you try this one please?
--- a/lib/kobject.c~a
+++ a/lib/kobject.c
@@ -126,6 +126,8 @@ static void kobj_kset_join(struct kobjec
kset_get(kobj->kset);
spin_lock(&kobj->kset->list_lock);
+ printk("kobj_kset_join:%p\n", kobj);
+ dump_stack();
list_add_tail(&kobj->entry, &kobj->kset->list);
spin_unlock(&kobj->kset->list_lock);
}
@@ -751,9 +753,12 @@ struct kobject *kset_find_obj(struct kse
spin_lock(&kset->list_lock);
list_for_each_entry(k, &kset->list, entry) {
- if (kobject_name(k) && !strcmp(kobject_name(k), name)) {
- ret = kobject_get(k);
- break;
+ if (kobject_name(k)) {
+ printk("kset_find_obj:%p\n", k);
+ if (!strcmp(kobject_name(k), name)) {
+ ret = kobject_get(k);
+ break;
+ }
}
}
spin_unlock(&kset->list_lock);
_
next prev parent reply other threads:[~2010-03-03 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100228221257.GA8858@invalid>
2010-03-01 4:22 ` 2.6.33 dies on modprobe Américo Wang
2010-03-01 9:07 ` M G Berberich
2010-03-03 8:58 ` Américo Wang
2010-03-03 9:08 ` Américo Wang
2010-03-03 9:18 ` Américo Wang
2010-03-03 2:52 ` Andrew Morton
2010-03-03 22:16 ` M G Berberich
2010-03-03 22:24 ` Andrew Morton [this message]
2010-03-04 0:05 ` Andrew Morton
2010-03-04 0:10 ` Randy Dunlap
[not found] <fa.S/rvLm1aQlDSqPwVJz5B+5vHjbM@ifi.uio.no>
[not found] ` <fa.+Pg2gFpQSg5k/1mCpBdt8xMXeqY@ifi.uio.no>
[not found] ` <fa.0/xGeZctWXDyX0DAp6opgP1HP7w@ifi.uio.no>
[not found] ` <fa.kPSENj9DWu0Q8xolQMDkRvAwxQ0@ifi.uio.no>
[not found] ` <fa.JUJQsT7bECqtd8JSoNY+SBdASCE@ifi.uio.no>
[not found] ` <fa.Lya/54V1PJgwjc8uy1Yk4NyYUh4@ifi.uio.no>
2010-03-03 23:04 ` M G Berberich
2010-03-04 15:30 ` Américo Wang
2010-03-04 20:38 ` M G Berberich
2010-03-07 15:41 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303142420.accf985e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=berberic@fmi.uni-passau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).