* [PATCH] cxgb3: fix hot plug removal crash
@ 2010-03-03 19:49 Divy Le Ray
2010-03-04 8:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Divy Le Ray @ 2010-03-03 19:49 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, swise, wenxiong
From: Divy Le Ray <divy@chelsio.com>
queue restart tasklets need to be stopped after napi handlers are stopped
since the latter can restart them. So stop them after stopping napi.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/cxgb3_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
index 6fd968a..cecdec1 100644
--- a/drivers/net/cxgb3/cxgb3_main.c
+++ b/drivers/net/cxgb3/cxgb3_main.c
@@ -1280,6 +1280,7 @@ static void cxgb_down(struct adapter *adapter)
free_irq_resources(adapter);
quiesce_rx(adapter);
+ t3_sge_stop(adapter);
flush_workqueue(cxgb3_wq); /* wait for external IRQ handler */
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb3: fix hot plug removal crash
2010-03-03 19:49 [PATCH] cxgb3: fix hot plug removal crash Divy Le Ray
@ 2010-03-04 8:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-04 8:39 UTC (permalink / raw)
To: divy; +Cc: netdev, linux-kernel, swise, wenxiong
From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 03 Mar 2010 11:49:47 -0800
> From: Divy Le Ray <divy@chelsio.com>
>
> queue restart tasklets need to be stopped after napi handlers are stopped
> since the latter can restart them. So stop them after stopping napi.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-04 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 19:49 [PATCH] cxgb3: fix hot plug removal crash Divy Le Ray
2010-03-04 8:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).