From: David Miller <davem@davemloft.net>
To: efault@gmx.de
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [rfc/rft][patch] should use scheduler sync hint in tcp_prequeue()?
Date: Thu, 04 Mar 2010 00:41:04 -0800 (PST) [thread overview]
Message-ID: <20100304.004104.24320938.davem@davemloft.net> (raw)
In-Reply-To: <1267627610.6264.21.camel@marge.simson.net>
From: Mike Galbraith <efault@gmx.de>
Date: Wed, 03 Mar 2010 15:46:50 +0100
> On Wed, 2010-03-03 at 06:05 -0800, David Miller wrote:
>
>> It definitely looks like an oversight to me and we should add
>> be using wake_up_interruptible_sync_poll() in tcp_prequeue()
>> as above.
>>
>> Ingo?
>
> Implied ack from network maintainer implies ship it to me.
>
> net: add scheduler sync hint to tcp_prequeue().
>
> Decreases the odds wakee will suffer from frequent cache misses.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
Applied.
next prev parent reply other threads:[~2010-03-04 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 9:41 [rfc/rft][patch] should use scheduler sync hint in tcp_prequeue()? Mike Galbraith
2010-03-02 11:27 ` Eric Dumazet
2010-03-02 11:32 ` Peter Zijlstra
2010-03-02 11:41 ` Mike Galbraith
2010-03-02 11:39 ` Mike Galbraith
2010-03-03 14:05 ` David Miller
2010-03-03 14:46 ` Mike Galbraith
2010-03-04 8:41 ` David Miller [this message]
2010-03-04 3:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304.004104.24320938.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).