From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] gre: fix hard header destination address checking
Date: Thu, 04 Mar 2010 00:41:10 -0800 (PST) [thread overview]
Message-ID: <20100304.004110.255528335.davem@davemloft.net> (raw)
In-Reply-To: <1267624874-22326-1-git-send-email-timo.teras@iki.fi>
From: Timo Teras <timo.teras@iki.fi>
Date: Wed, 3 Mar 2010 16:01:13 +0200
> ipgre_header() can be called with zero daddr when the gre device is
> configured as multipoint tunnel and still has the NOARP flag set (which is
> typically cleared by the userspace arp daemon). If the NOARP packets are
> not dropped, ipgre_tunnel_xmit() will take rt->rt_gateway (= NBMA IP) and
> use that for route look up (and may lead to bogus xfrm acquires).
>
> The multicast address check is removed as sending to multicast group should
> be ok. In fact, if gre device has a multicast address as destination
> ipgre_header is always called with multicast address.
>
> Signed-off-by: Timo Teras <timo.teras@iki.fi>
Applied.
prev parent reply other threads:[~2010-03-04 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 14:01 [PATCH 1/2] gre: fix hard header destination address checking Timo Teras
2010-03-03 14:01 ` [PATCH 2/2] ipv4: flush ARP entries on device change Timo Teras
2010-03-03 14:06 ` Patrick McHardy
2010-03-03 14:20 ` Timo Teräs
2010-03-03 14:33 ` Patrick McHardy
2010-03-03 14:39 ` Timo Teräs
2010-03-03 14:44 ` Patrick McHardy
2010-03-04 11:15 ` Timo Teräs
2010-03-04 8:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304.004110.255528335.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).