From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jussi.kivilinna-E01nCVcF24I@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [net-next-2.6 PATCH] wireless: convert to use netdev_for_each_mc_addr
Date: Thu, 04 Mar 2010 00:52:46 -0800 (PST) [thread overview]
Message-ID: <20100304.005246.240968829.davem@davemloft.net> (raw)
In-Reply-To: <20100304.004150.129762672.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Date: Thu, 04 Mar 2010 00:41:50 -0800 (PST)
> From: Jiri Pirko <jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date: Wed, 3 Mar 2010 19:09:56 +0100
>
>> Here's corrected patch:
>>
>> Subject: [net-2.6 PATCH] rndis_wlan: correct multicast_list handling V2
>>
>> My previous patch (655ffee284dfcf9a24ac0343f3e5ee6db85b85c5) added locking in
>> a bad way. Because rndis_set_oid can sleep, there is need to prepare multicast
>> addresses into local buffer under netif_addr_lock first, then call
>> rndis_set_oid outside. This caused reorganizing of the whole function.
>>
>> Signed-off-by: Jiri Pirko <jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> Reported-by: Jussi Kivilinna <jussi.kivilinna-E01nCVcF24I@public.gmane.org>
>
> Applied.
Jiri did ou even type make on this patch? The 'size' is still
referenced:
drivers/net/wireless/rndis_wlan.c: In function 'set_multicast_list':
drivers/net/wireless/rndis_wlan.c:1530: error: 'size' undeclared (first use in this function)
drivers/net/wireless/rndis_wlan.c:1530: error: (Each undeclared identifier is reported only once
drivers/net/wireless/rndis_wlan.c:1530: error: for each function it appears in.)
I reverted, and I'm pissed off.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-04 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 9:45 [net-next-2.6 PATCH] wireless: convert to use netdev_for_each_mc_addr Jussi Kivilinna
2010-03-03 10:01 ` David Miller
2010-03-03 12:42 ` Jiri Pirko
2010-03-03 16:42 ` Jussi Kivilinna
2010-03-03 17:52 ` Jiri Pirko
2010-03-03 18:05 ` Jussi Kivilinna
2010-03-03 18:09 ` Jiri Pirko
2010-03-04 8:41 ` David Miller
[not found] ` <20100304.004150.129762672.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-03-04 8:52 ` David Miller [this message]
2010-03-04 9:20 ` Jiri Pirko
2010-03-04 11:38 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-02-27 17:35 Jiri Pirko
2010-02-28 9:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304.005246.240968829.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jussi.kivilinna-E01nCVcF24I@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).