From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_ macros to functions Date: Thu, 4 Mar 2010 16:56:09 -0800 Message-ID: <20100304165609.20849b93.akpm@linux-foundation.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , Nick Andrew , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , netdev@vger.kernel.org To: Joe Perches Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:52688 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189Ab0CEA4U (ORCPT ); Thu, 4 Mar 2010 19:56:20 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches wrote: > Save ~60k in a defconfig > > Use %pV and struct va_format > Format arguments are verified before printk Well that doesn't work very well. drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol include/linux/device.h:645: error: previous declaration of 'dev_info' was here there are lots of other dev_info's which will fail plus perhaps dev_err's, etc.