From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix netdev_printk null dereference
Date: Fri, 05 Mar 2010 06:39:09 -0800 (PST) [thread overview]
Message-ID: <20100305.063909.26489418.davem@davemloft.net> (raw)
In-Reply-To: <1267793225-426-1-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Fri, 5 Mar 2010 12:47:05 +0000
> This patch fixes a reproducible null dereference in smsc95xx (and I
> suspect others) when the device is removed during a control register
> access. This can be reproduced by rapidly plugging and unplugging
> the device during its initialisation.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
The parent shouldn't become NULL until the device is totally quiesced
and is no longer accesses.
Maybe you can instead fix the smsc95xx driver to abide by this rule
instead of adding a conditional check to thousands of other drivers in
the tree that do not need this?
I really have no intention of adding your change, please fix this
properly, thanks.
next prev parent reply other threads:[~2010-03-05 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 12:47 [PATCH] Fix netdev_printk null dereference Steve Glendinning
2010-03-05 14:39 ` David Miller [this message]
2010-03-05 14:50 ` Joe Perches
2010-03-05 15:03 ` David Miller
2010-03-05 15:29 ` Steve.Glendinning
2010-03-05 15:43 ` David Miller
2010-03-05 16:32 ` Steve.Glendinning
2010-03-05 16:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305.063909.26489418.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).