From: David Miller <davem@davemloft.net>
To: Steve.Glendinning@smsc.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix netdev_printk null dereference
Date: Fri, 05 Mar 2010 07:43:35 -0800 (PST) [thread overview]
Message-ID: <20100305.074335.248610315.davem@davemloft.net> (raw)
In-Reply-To: <OF33DF005A.0C447DF0-ON802576DD.00538FB8-802576DD.00552375@smsc.com>
From: Steve.Glendinning@smsc.com
Date: Fri, 5 Mar 2010 15:29:41 +0000
> The failure I'm seeing is caused when the usb device is disconnected.
> smsc95xx detects that a pending USB control operation failed
> and tries to print a message via netdev_printk to report this.
>
> Unfortunately, something else (the USB subsystem?) has already set
> parent to null at this time so the netdev_printk causes a null
> dereference.
>
> So netdev_printk suddenly changes from safe to use to unsafe to use?
It seems to me that really you only need this parent NULL check where
you notice the USB control operation failed and want to print a
message about that.
That should cover all the necessary cases shouldn't it?
Even more importantly, why does a USB disconnect NULL out the netdev
parent device pointer? Until you actually release this USB device in
the driver, the parent pointer should stay there.
next prev parent reply other threads:[~2010-03-05 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 12:47 [PATCH] Fix netdev_printk null dereference Steve Glendinning
2010-03-05 14:39 ` David Miller
2010-03-05 14:50 ` Joe Perches
2010-03-05 15:03 ` David Miller
2010-03-05 15:29 ` Steve.Glendinning
2010-03-05 15:43 ` David Miller [this message]
2010-03-05 16:32 ` Steve.Glendinning
2010-03-05 16:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305.074335.248610315.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Steve.Glendinning@smsc.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).