From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org, gospo@redhat.com
Subject: Re: [PATCH v4] ethtool: Add direct access to ops->get_sset_count
Date: Fri, 05 Mar 2010 14:00:39 -0800 (PST) [thread overview]
Message-ID: <20100305.140039.122978684.davem@davemloft.net> (raw)
In-Reply-To: <4B8FB439.8050901@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Thu, 04 Mar 2010 08:23:05 -0500
> On 03/04/2010 03:51 AM, Jeff Kirsher wrote:
>> From: Jeff Garzik<jgarzik@redhat.com>
>>
>> This patch is an alternative approach for accessing string
>> counts, vs. the drvinfo indirect approach. This way the drvinfo
>> space doesn't run out, and we don't break ABI later.
>>
>> Signed-off-by: Jeff Garzik<jgarzik@redhat.com>
>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
>> ---
>>
>> include/linux/ethtool.h | 17 +++++++++--
>> net/core/ethtool.c | 72
>> +++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 86 insertions(+), 3 deletions(-)
>
> Both patches look good to me. There is a cosmetic issue of needing to
> sync up userspace and kernel ethtool.h WRT whitespace and deleted
> constants, but I can do that after DaveM applies this patch.
>
> Waiting for upstream application, or other objections...
Applied, thanks guys.
next prev parent reply other threads:[~2010-03-05 22:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 8:51 [PATCH v4] ethtool: Add direct access to ops->get_sset_count Jeff Kirsher
2010-03-04 13:23 ` Jeff Garzik
2010-03-05 22:00 ` David Miller [this message]
2010-03-04 14:26 ` Ben Hutchings
2010-03-04 18:21 ` [PATCH] " Jeff Garzik
2010-03-05 22:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305.140039.122978684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).