From: David Miller <davem@davemloft.net>
To: ken_kawasaki@spring.nifty.jp
Cc: netdev@vger.kernel.org
Subject: Re: [kernel,2.6.33-git11] lib8390: use spin_lock_irqsave for locking
Date: Sun, 07 Mar 2010 15:22:30 -0800 (PST) [thread overview]
Message-ID: <20100307.152230.09914483.davem@davemloft.net> (raw)
This change is not correct.
disable_irq is being intentionally used because the reset
sequence can take a very long time and we don't want to
have cpu interrupts disabled during the entire sequence.
Otherwise slow serial devices will drop characters and
stuff like that.
next reply other threads:[~2010-03-07 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 23:22 David Miller [this message]
2010-03-08 12:24 ` [kernel,2.6.33-git11] lib8390: use spin_lock_irqsave for locking Ken Kawasaki
2010-03-08 17:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100307.152230.09914483.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).