From: David Miller <davem@davemloft.net>
To: ken_kawasaki@spring.nifty.jp
Cc: netdev@vger.kernel.org
Subject: Re: [kernel,2.6.33-git11] lib8390: use spin_lock_irqsave for locking
Date: Mon, 08 Mar 2010 09:56:37 -0800 (PST) [thread overview]
Message-ID: <20100308.095637.175882761.davem@davemloft.net> (raw)
In-Reply-To: <20100308212433.0fa3e453.ken_kawasaki@spring.nifty.jp>
From: Ken Kawasaki <ken_kawasaki@spring.nifty.jp>
Date: Mon, 8 Mar 2010 21:24:33 +0900
>
>> This change is not correct.
>>
>> disable_irq is being intentionally used because the reset
>> sequence can take a very long time and we don't want to
>> have cpu interrupts disabled during the entire sequence.
>>
>> Otherwise slow serial devices will drop characters and
>> stuff like that.
>
>
> Actually, disable_irq is _not_ safe for lib8390 on SMP system.
> Same CPU or other CPU can call enable_irq.
>
> so lib8390 does not work properly on my SMP system.
Then you need to fix that bug, because your patch here, again,
is not correct.
prev parent reply other threads:[~2010-03-08 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 23:22 [kernel,2.6.33-git11] lib8390: use spin_lock_irqsave for locking David Miller
2010-03-08 12:24 ` Ken Kawasaki
2010-03-08 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308.095637.175882761.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).