From: Jiri Pirko <jpirko@redhat.com>
To: Guy Harris <guy@alum.mit.edu>
Cc: tcpdump-workers@lists.tcpdump.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [tcpdump-workers] Current wireless-testing breaks libpcap: mr_alen should be set
Date: Mon, 8 Mar 2010 09:11:35 +0100 [thread overview]
Message-ID: <20100308081134.GA2816@psychotron.redhat.com> (raw)
In-Reply-To: <7D621661-59E7-46C4-9E86-1D9654A626E7@alum.mit.edu>
Sat, Mar 06, 2010 at 10:23:12PM CET, guy@alum.mit.edu wrote:
>
>On Mar 2, 2010, at 5:00 PM, Pavel Roskin wrote:
>
>> This patch to libpcap helps:
>>
>> --- a/pcap-linux.c
>> +++ b/pcap-linux.c
>> @@ -1563,6 +1563,7 @@ live_open_new(pcap_t *handle, const char
>> memset(&mr, 0, sizeof(mr));
>> mr.mr_ifindex = handle->md.ifindex;
>> mr.mr_type = PACKET_MR_PROMISC;
>> + mr.mr_alen = 6;
>
>If there are any network types that support promiscuous mode and have link-layer addresses that aren't 6 octets long, that would still fail.
>
>It sounds as if the fix is not to care about the address length if the address isn't used, so you don't need to get the length right for PACKET_MR_PROMISC or PACKET_MR_ALLMULTI, so libpcap, and other clients setting promiscuous or "show me all multicast packets" mode, don't need to change. Is that the case?
This should be fixed in kernel (net-2.6
1162563f82b434e3099c9e6c1bbdba846d792f0d)
Jirka
prev parent reply other threads:[~2010-03-08 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 1:00 Current wireless-testing breaks libpcap: mr_alen should be set Pavel Roskin
2010-03-03 2:36 ` John W. Linville
2010-03-03 6:24 ` Jiri Pirko
2010-03-03 6:57 ` Pavel Roskin
2010-03-03 6:40 ` [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del] Jiri Pirko
2010-03-03 7:01 ` Pavel Roskin
2010-03-03 7:36 ` Jiri Pirko
[not found] ` <20100303064001.GB2648-YzwxZg+R7et1/kRsl7OVgNvLeJWuRmrY@public.gmane.org>
2010-03-03 6:57 ` Eric Dumazet
2010-03-03 9:05 ` Jiri Pirko
[not found] ` <20100303090512.GB2961-YzwxZg+R7evMbnheQZGK0N5OCZ2W11yPFxja6HXR22MAvxtiuMwx3w@public.gmane.org>
2010-03-03 9:06 ` David Miller
2010-03-03 9:06 ` David Miller
2010-03-03 15:31 ` Current wireless-testing breaks libpcap: mr_alen should be set Frank W. Miller
2010-03-03 15:54 ` [tcpdump-workers] " Jiri Pirko
2010-03-06 21:23 ` Guy Harris
2010-03-08 8:11 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308081134.GA2816@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=guy@alum.mit.edu \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tcpdump-workers@lists.tcpdump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).