netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: frank.blaschka@de.ibm.com
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [patch 5/5] [PATCH] qeth: change checksumming default for HiperSockets
Date: Tue, 09 Mar 2010 07:36:57 +0100	[thread overview]
Message-ID: <20100309063937.049755000@de.ibm.com> (raw)
In-Reply-To: 20100309063652.706791000@de.ibm.com

[-- Attachment #1: 606-qeth-checksum-default.diff --]
[-- Type: text/plain, Size: 801 bytes --]

From: Frank Blaschka <frank.blaschka@de.ibm.com>

Deactivate inbound checksumming on HiperSocket is a valid but
dangerous optimization in case the frame is routed from an OSA
network to an HiperSockets network. To go for sure we change the
default to software checksumming.

Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
---

 drivers/s390/net/qeth_core_main.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -1114,8 +1114,6 @@ static int qeth_setup_card(struct qeth_c
 	card->ipato.enabled = 0;
 	card->ipato.invert4 = 0;
 	card->ipato.invert6 = 0;
-	if (card->info.type == QETH_CARD_TYPE_IQD)
-		card->options.checksum_type = NO_CHECKSUMMING;
 	/* init QDIO stuff */
 	qeth_init_qdio_info(card);
 	return 0;


  parent reply	other threads:[~2010-03-09  6:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09  6:36 [patch 0/5] qeth bug fixes for 2.6.34 next rc frank.blaschka
2010-03-09  6:36 ` [patch 1/5] [PATCH] qeth: enable kmsg hash processing in qeth_core_sys.c frank.blaschka
2010-03-09  6:36 ` [patch 2/5] [PATCH] qeth: l3 send dhcp in non pass thru mode frank.blaschka
2010-03-09  6:36 ` [patch 3/5] [PATCH] qeth: set promisc off after trace disabling failure frank.blaschka
2010-03-09  6:36 ` [patch 4/5] [PATCH] qeth: no recovery after layer mismatch (z/VM NICs) frank.blaschka
2010-03-09  6:36 ` frank.blaschka [this message]
2010-03-10 15:32 ` [patch 0/5] qeth bug fixes for 2.6.34 next rc David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100309063937.049755000@de.ibm.com \
    --to=frank.blaschka@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).