From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Vladislav Zolotarov <vladz@broadcom.com>,
David Miller <davem@davemloft.net>,
paulmck@linux.vnet.ibm.com, netdev@vger.kernel.org,
Eilon Greenstein <eilong@broadcom.com>
Subject: Re: [RFC PATCH] bnx2x: fix tx queue locking and memory barriers
Date: Thu, 11 Mar 2010 14:10:28 +0100 [thread overview]
Message-ID: <20100311131027.GA5040@dhcp-lab-161.englab.brq.redhat.com> (raw)
In-Reply-To: <31355.1268240990@redhat.com>
On Wed, Mar 10, 2010 at 05:09:50PM +0000, David Howells wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> wrote:
>
> > - barrier(); /* Tell compiler that prod and cons can change */
> > + /* prod and cons can change on other cpu, want to see
> > + consistend available space and queue (stop/running) state */
> > + smp_mb();
> > +
> > prod = fp->tx_bd_prod;
> > cons = fp->tx_bd_cons;
>
> I suspect that this isn't what you want.
Yes, I realized that. I posted other patches, removing you from CC, since
thought you are not interested.
http://patchwork.ozlabs.org/patch/47172/
http://patchwork.ozlabs.org/patch/47173/
http://patchwork.ozlabs.org/patch/47174/
I removed there barrier() and not use smp_mb(), with explanation why.
Stanislaw
next prev parent reply other threads:[~2010-03-11 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 13:08 [RFC PATCH] bnx2x: fix tx queue locking and memory barriers Stanislaw Gruszka
2010-02-25 10:18 ` David Miller
2010-02-25 15:40 ` Stanislaw Gruszka
2010-02-25 15:49 ` Vladislav Zolotarov
2010-02-25 16:03 ` Stanislaw Gruszka
2010-02-25 16:06 ` David Miller
2010-02-25 16:16 ` Stanislaw Gruszka
2010-02-25 16:14 ` Vladislav Zolotarov
2010-02-25 13:28 ` Vladislav Zolotarov
2010-03-10 17:09 ` David Howells
2010-03-10 17:49 ` David Miller
2010-03-10 18:32 ` David Howells
2010-03-11 13:10 ` Stanislaw Gruszka [this message]
2010-03-10 17:19 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311131027.GA5040@dhcp-lab-161.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).