From: Stephen Hemminger <shemminger@vyatta.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: core: add IFLA_STATS64 support
Date: Thu, 11 Mar 2010 14:50:59 -0800 [thread overview]
Message-ID: <20100311145059.1a020e1c@nehalam> (raw)
In-Reply-To: <alpine.LSU.2.01.1003112305060.11569@obet.zrqbmnf.qr>
On Thu, 11 Mar 2010 23:13:18 +0100 (CET)
Jan Engelhardt <jengelh@medozas.de> wrote:
> On Thursday 2010-03-11 23:04, Stephen Hemminger wrote:
> >> >> `ip -s link` shows interface counters truncated to 32 bit. This is
> >> >> because interface statistics are transported only in 32-bit quantity
> >> >> to userspace. This commit adds a new IFLA_STATS64 attribute that
> >> >> exports them in full 64 bit.
> >>
> >> On 64-bit it has 64-bit counters, yet we only report 32-bit
> >> counters to userspace via netlink even in that case.
> >
> >That make sense, but maybe we shouldn't send IFLA_STATS64 on
> >32bit platforms.
>
> Somehow I'd prefer to have consistency. Platform-specific
> actions and/or payload I think we already were plagued enough by
> syscalls and iptables. (Just to name two.)
But if you send 32bit truncated values when 64 bit is expected
then users are going to complain
--
next prev parent reply other threads:[~2010-03-11 22:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 19:57 [net-next] IFLA_STATS64, tcp cong modules Jan Engelhardt
2010-03-11 19:57 ` [PATCH 1/3] net: tcp: make hybla selectable as default congestion module Jan Engelhardt
2010-03-11 20:10 ` Stephen Hemminger
2010-03-11 20:19 ` Jan Engelhardt
2010-03-17 4:29 ` David Miller
2010-03-11 19:57 ` [PATCH 2/3] net: tcp: make veno " Jan Engelhardt
2010-03-17 4:29 ` David Miller
2010-03-11 19:57 ` [PATCH 3/3] net: core: add IFLA_STATS64 support Jan Engelhardt
2010-03-11 20:12 ` Stephen Hemminger
2010-03-11 20:26 ` David Miller
2010-03-11 21:07 ` Jan Engelhardt
2010-03-11 21:30 ` David Miller
2010-03-11 22:04 ` Stephen Hemminger
2010-03-11 22:13 ` Jan Engelhardt
2010-03-11 22:50 ` Stephen Hemminger [this message]
2010-03-11 22:54 ` David Miller
2010-03-11 23:10 ` Stephen Hemminger
2010-03-11 23:15 ` David Miller
2010-03-11 23:44 ` Stephen Hemminger
2010-03-11 22:13 ` David Miller
2010-03-11 22:15 ` Jan Engelhardt
2010-03-11 20:19 ` Eric Dumazet
2010-03-17 4:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311145059.1a020e1c@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).