From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: [patch 2/5] atm: use for_each_set_bit() Date: Thu, 11 Mar 2010 14:07:50 -0800 Message-ID: <201003112207.o2BM7o2e013489@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, akinobu.mita@gmail.com, chas@cmf.nrl.navy.mil To: davem@davemloft.net Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:58088 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758273Ab0CKWIK (ORCPT ); Thu, 11 Mar 2010 17:08:10 -0500 Sender: netdev-owner@vger.kernel.org List-ID: From: Akinobu Mita Replace open-coded loop with for_each_set_bit(). Signed-off-by: Akinobu Mita Cc: Chas Williams Signed-off-by: Andrew Morton --- drivers/atm/lanai.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff -puN drivers/atm/lanai.c~atm-use-for_each_set_bit drivers/atm/lanai.c --- a/drivers/atm/lanai.c~atm-use-for_each_set_bit +++ a/drivers/atm/lanai.c @@ -306,11 +306,10 @@ static void vci_bitfield_iterate(struct const unsigned long *lp, void (*func)(struct lanai_dev *,vci_t vci)) { - vci_t vci = find_first_bit(lp, NUM_VCI); - while (vci < NUM_VCI) { + vci_t vci; + + for_each_set_bit(vci, lp, NUM_VCI) func(lanai, vci); - vci = find_next_bit(lp, NUM_VCI, vci + 1); - } } /* -------------------- BUFFER UTILITIES: */ _