From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.34-rc1: rcu lockdep bug?
Date: Fri, 12 Mar 2010 00:07:05 -0800 (PST) [thread overview]
Message-ID: <20100312.000705.225033546.davem@davemloft.net> (raw)
In-Reply-To: <2375c9f91003112356g1b4164e4pb5f63f0e0e2f310a@mail.gmail.com>
From: Américo Wang <xiyou.wangcong@gmail.com>
Date: Fri, 12 Mar 2010 15:56:03 +0800
> Ok, after decoding the lockdep output, it looks like that
> netif_receive_skb() should call rcu_read_lock_bh() instead of rcu_read_lock()?
> But I don't know if all callers of netif_receive_skb() are in softirq context.
Normally, netif_receive_skb() is invoked from softirq context.
However, via netpoll it can be invoked essentially from any context.
But, when this happens, the networking receive path makes amends such
that this works fine. That's what the netpoll_receive_skb() check in
netif_receive_skb() is for. That check makes it bail out early if the
call to netif_receive_skb() is via a netpoll invocation.
next prev parent reply other threads:[~2010-03-12 8:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2375c9f91003110205v1d7f00bfk89472cb11bd985d3@mail.gmail.com>
[not found] ` <20100311134556.GA6344@linux.vnet.ibm.com>
[not found] ` <20100311161751.GA3804@hack>
2010-03-12 7:56 ` 2.6.34-rc1: rcu lockdep bug? Américo Wang
2010-03-12 8:07 ` David Miller [this message]
2010-03-12 8:59 ` Américo Wang
2010-03-12 11:11 ` Eric Dumazet
2010-03-12 13:11 ` Américo Wang
2010-03-12 13:37 ` Eric Dumazet
2010-03-13 5:33 ` Américo Wang
2010-03-13 21:58 ` Paul E. McKenney
2010-03-15 1:08 ` Américo Wang
2010-03-15 3:10 ` Américo Wang
2010-03-15 9:39 ` Américo Wang
2010-03-15 10:04 ` Eric Dumazet
2010-03-15 10:12 ` Américo Wang
2010-03-15 10:41 ` Eric Dumazet
2010-03-16 10:26 ` Américo Wang
2010-03-12 22:03 ` Paul E. McKenney
2010-03-13 5:31 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312.000705.225033546.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).