From: David Miller <davem@davemloft.net>
To: sjharms@gmail.com
Cc: mcarlson@broadcom.com, mchan@broadcom.com, benli@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sharms@ubuntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guidelines and verified by checkpatch.pl tool.
Date: Sat, 13 Mar 2010 11:49:39 -0800 (PST) [thread overview]
Message-ID: <20100313.114939.120459447.davem@davemloft.net> (raw)
In-Reply-To: <1268509151-27281-1-git-send-email-sharms@ubuntu.com>
From: Steven Harms <sjharms@gmail.com>
Date: Sat, 13 Mar 2010 14:39:11 -0500
> -#define tw32_mailbox(reg, val) tp->write32_mbox(tp, reg, val)
> -#define tw32_mailbox_f(reg, val) tw32_mailbox_flush(tp, (reg), (val))
> -#define tw32_rx_mbox(reg, val) tp->write32_rx_mbox(tp, reg, val)
> -#define tw32_tx_mbox(reg, val) tp->write32_tx_mbox(tp, reg, val)
> -#define tr32_mailbox(reg) tp->read32_mbox(tp, reg)
> +#define tw32_mailbox(reg, val) (tp->write32_mbox(tp, reg, val))
Please keep this kind of code masterbation to yourself.
This is not the style we want for this driver.
prev parent reply other threads:[~2010-03-13 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 19:39 [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guidelines and verified by checkpatch.pl tool Steven Harms
2010-03-13 19:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313.114939.120459447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sharms@ubuntu.com \
--cc=sjharms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).