* [PATCH] drivers/net/tg3.c: change the field used with the TG3_FLAG_10_100_ONLY constant
@ 2010-03-13 9:01 Julia Lawall
2010-03-13 20:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-03-13 9:01 UTC (permalink / raw)
To: Matt Carlson, Michael Chan, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The constant TG3_FLAG_10_100_ONLY should be used with the tg3_flags field,
not the tg3_flags2 field, as done elsewhere in the same file.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 0fa7688..fa8fb1a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -9776,7 +9776,7 @@ static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
ADVERTISED_Pause |
ADVERTISED_Asym_Pause;
- if (!(tp->tg3_flags2 & TG3_FLAG_10_100_ONLY))
+ if (!(tp->tg3_flags & TG3_FLAG_10_100_ONLY))
mask |= ADVERTISED_1000baseT_Half |
ADVERTISED_1000baseT_Full;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/tg3.c: change the field used with the TG3_FLAG_10_100_ONLY constant
2010-03-13 9:01 [PATCH] drivers/net/tg3.c: change the field used with the TG3_FLAG_10_100_ONLY constant Julia Lawall
@ 2010-03-13 20:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-13 20:22 UTC (permalink / raw)
To: julia; +Cc: mcarlson, mchan, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sat, 13 Mar 2010 10:01:09 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> The constant TG3_FLAG_10_100_ONLY should be used with the tg3_flags field,
> not the tg3_flags2 field, as done elsewhere in the same file.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks a lot Julia.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-13 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-13 9:01 [PATCH] drivers/net/tg3.c: change the field used with the TG3_FLAG_10_100_ONLY constant Julia Lawall
2010-03-13 20:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).