From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
peterz@infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: 2.6.34-rc1: rcu lockdep bug?
Date: Sat, 13 Mar 2010 13:58:38 -0800 [thread overview]
Message-ID: <20100313215838.GB6805@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100313053356.GC3704@hack>
On Sat, Mar 13, 2010 at 01:33:56PM +0800, Américo Wang wrote:
> On Fri, Mar 12, 2010 at 02:37:38PM +0100, Eric Dumazet wrote:
> >Le vendredi 12 mars 2010 à 21:11 +0800, Américo Wang a écrit :
> >
> >> Oh, but lockdep complains about rcu_read_lock(), it said
> >> rcu_read_lock() can't be used in softirq context.
> >>
> >> Am I missing something?
> >
> >Well, lockdep might be dumb, I dont know...
> >
> >I suggest you read rcu_read_lock_bh kernel doc :
> >
> >/**
> > * rcu_read_lock_bh - mark the beginning of a softirq-only RCU critical
> >section
> > *
> > * This is equivalent of rcu_read_lock(), but to be used when updates
> > * are being done using call_rcu_bh(). Since call_rcu_bh() callbacks
> > * consider completion of a softirq handler to be a quiescent state,
> > * a process in RCU read-side critical section must be protected by
> > * disabling softirqs. Read-side critical sections in interrupt context
> > * can use just rcu_read_lock().
> > *
> > */
> >
> >
> >Last sentence being perfect :
> >
> >Read-side critical sections in interrupt context
> >can use just rcu_read_lock().
> >
>
> Yeah, right, then it is more likely to be a bug of rcu lockdep.
> Paul is looking at it.
Except that it seems to be working correctly for me...
Thanx, Paul
next prev parent reply other threads:[~2010-03-13 21:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2375c9f91003110205v1d7f00bfk89472cb11bd985d3@mail.gmail.com>
[not found] ` <20100311134556.GA6344@linux.vnet.ibm.com>
[not found] ` <20100311161751.GA3804@hack>
2010-03-12 7:56 ` 2.6.34-rc1: rcu lockdep bug? Américo Wang
2010-03-12 8:07 ` David Miller
2010-03-12 8:59 ` Américo Wang
2010-03-12 11:11 ` Eric Dumazet
2010-03-12 13:11 ` Américo Wang
2010-03-12 13:37 ` Eric Dumazet
2010-03-13 5:33 ` Américo Wang
2010-03-13 21:58 ` Paul E. McKenney [this message]
2010-03-15 1:08 ` Américo Wang
2010-03-15 3:10 ` Américo Wang
2010-03-15 9:39 ` Américo Wang
2010-03-15 10:04 ` Eric Dumazet
2010-03-15 10:12 ` Américo Wang
2010-03-15 10:41 ` Eric Dumazet
2010-03-16 10:26 ` Américo Wang
2010-03-12 22:03 ` Paul E. McKenney
2010-03-13 5:31 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313215838.GB6805@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).