From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ajitk@serverengines.com, ajitkhaparde@gmail.com, jeff@garzik.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool.h: Add "structs are public" disclaimer comment
Date: Sun, 14 Mar 2010 15:08:18 -0700 (PDT) [thread overview]
Message-ID: <20100314.150818.124884915.davem@davemloft.net> (raw)
In-Reply-To: <1268583478.30289.94.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Sun, 14 Mar 2010 09:17:58 -0700
> On Sat, 2010-03-13 at 18:11 -0800, David Miller wrote:
>> For the millionth time, you cannot change these datastructures
>> like this without breaking all existing userspace applications
>> out there.
>
> Maybe this might help reduce the broken record repetitiveness.
>
> Signed-off-by: Joe Perches <joe@perches.com>
That's rediculious. Just about every single file in
include/linux/foo.h has similar stuff.
And we already have a way to document this, the fact that a header
file appears in include/linux/Kbuild shows that it provides userland
interfaces.
And your comment wouldn't help this person at all, they _KNEW_ it
changed userspace, because in the very next patch they patch the
userland tool to change the datastructures too!
next prev parent reply other threads:[~2010-03-14 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 1:43 [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams Ajit Khaparde
2010-03-14 2:11 ` David Miller
2010-03-14 16:17 ` [PATCH] ethtool.h: Add "structs are public" disclaimer comment Joe Perches
2010-03-14 17:50 ` Ben Hutchings
2010-03-14 18:38 ` Jeff Garzik
2010-03-14 22:08 ` David Miller [this message]
2010-03-14 4:21 ` [RFC PATCH net-2.6] net/ethtool: add multiple queue support to {get,set}_ringparams Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314.150818.124884915.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=ajitkhaparde@gmail.com \
--cc=jeff@garzik.org \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).