netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: isdn@linux-pingi.de
Cc: tilman@imap.cc, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	isdn4linux@listserv.isdn4linux.de, hjlipp@web.de,
	i4ldeveloper@listserv.isdn4linux.de
Subject: Re: [1/3] gigaset: avoid registering CAPI driver more than once
Date: Mon, 15 Mar 2010 14:20:40 -0700 (PDT)	[thread overview]
Message-ID: <20100315.142040.58983190.davem@davemloft.net> (raw)
In-Reply-To: <1268664986.25524@pingi>


Karsten the way you reforward patches does not work.

And I've told you about this last time you submitted ISDN patches.

You don't add an extra "From: " line in the message body, so when the
patch gets applied the author gets set to _you_ instead of the person
who actually wrote the change.

All you're doing is ACK'ing this person's work, so simply reply to the
patch they posted and with your "Acked-by" line.  This way patchwork
and friends will figure out the rest when the patch gets integrated
into the net-2.6 tree.

By reposting the patches the way you are we're losing information.

Add to this the fact that you never have the time to properly take
care of ISDN patches, and when you do finally "get to it" you make all
kinds of submission errors.

This is not the first time either, it happens over and over again.
It's incredibly frustrating, especially for me.

Please seriously consider handing ISDN maintainership over to someone
who unlike you 1) has the time and the desire and 2) knows how to
submit patches properly.  Probably Tilman is the person who most meets
these criteria based upon what I've seen.

Meanwhile, I'm going to apply the original patches as posted by
Tilman so that the proper authorship gets set.

  reply	other threads:[~2010-03-15 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 14:48 [1/3] gigaset: avoid registering CAPI driver more than once Karsten Keil
2010-03-15 21:20 ` David Miller [this message]
2010-03-16  0:23   ` Karsten Keil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315.142040.58983190.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hjlipp@web.de \
    --cc=i4ldeveloper@listserv.isdn4linux.de \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=isdn@linux-pingi.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).