From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/6] smsc95xx: add constant definition for SMSC USB vendor id
Date: Mon, 15 Mar 2010 15:39:01 -0700 (PDT) [thread overview]
Message-ID: <20100315.153901.70730692.davem@davemloft.net> (raw)
In-Reply-To: <1268245959-13861-4-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Wed, 10 Mar 2010 18:32:36 +0000
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
I don't see any real need for this, really. It's a constant,
device ID tables are constants and people know how to go lookup
a vendor ID if they really want to know who it is. This doesn't
add any readability to the driver at all.
Also you're mixing cleanups and bug fixes into your patch
set. Please seperate out the pure bug fixes so I can apply
them to net-2.6 The rest can go in later when net-next-2.6
opens up.
prev parent reply other threads:[~2010-03-15 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 18:32 [PATCH 0/6] smsc95xx: minor fixes and tidy-ups Steve Glendinning
2010-03-10 18:32 ` [PATCH 1/6] smsc95xx: change hard_header_len to include csum offload bytes Steve Glendinning
2010-03-10 18:32 ` [PATCH 2/6] smsc95xx: wait for PHY to complete reset during init Steve Glendinning
2010-03-10 18:32 ` [PATCH 3/6] smsc95xx: add constant definition for SMSC USB vendor id Steve Glendinning
2010-03-10 18:32 ` [PATCH 4/6] smsc95xx: sleep before read for lengthy operations Steve Glendinning
2010-03-10 18:32 ` [PATCH 5/6] smsc95xx: check return code from control messages Steve Glendinning
2010-03-10 18:32 ` [PATCH 6/6] smsc95xx: remove unnecessary variables Steve Glendinning
2010-03-12 13:32 ` [PATCH 5/6] smsc95xx: check return code from control messages Steve.Glendinning
2010-03-15 22:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.153901.70730692.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).