From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: ram.vepa@neterion.com, santosh.rastapur@neterion.com,
sivakumar.subramani@neterion.com, sreenivasa.honnur@neterion.com,
anil.murthy@neterion.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/net: drop redundant memset
Date: Mon, 15 Mar 2010 15:47:14 -0700 (PDT) [thread overview]
Message-ID: <20100315.154714.23695928.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1003092213500.4974@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Tue, 9 Mar 2010 22:14:11 +0100 (CET)
> From: Julia Lawall <julia@diku.dk>
>
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2,e3,e4;
> @@
>
> - memset(e1,e2,e3);
> memcpy(e1,e4,e3);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks!
next parent reply other threads:[~2010-03-15 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.1003092213500.4974@ask.diku.dk>
2010-03-15 22:47 ` David Miller [this message]
2010-03-09 21:14 [PATCH 2/5] drivers/net: drop redundant memset Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.154714.23695928.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anil.murthy@neterion.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).